Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add docs for dynamic font scaling #3111
docs: add docs for dynamic font scaling #3111
Changes from 14 commits
f05e854
2ef4ef2
a9c4033
cf55ded
9e2fb3d
0512a89
35fa744
1d497f6
1ad12ab
b7d4ef9
80e48a6
d16510a
c105df8
b37af9d
d0f06cd
d94841f
0ed0b00
ae4f3b7
7263c8a
cbe79e4
bf423b5
175036f
338b473
a4ad895
075b66f
83aca72
e9a79a3
5afefa5
7eac2a3
ab09deb
1997d20
85f54d0
03febb1
a9e1238
a5c09e6
46083a6
b0360df
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we put this in a playground demo with just a javascript example? I know you don't need ionic for this, so we could override the index file and keep it simple.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that may be overkill since that's going to show you Angular, React, and Vue code snippets which really aren't need. The purpose of this is to demonstrate how part of CSS works.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm confused by this entire section. We aren't using
min
,max
orclamp
on Android values in Ionic and this section is underHow Dynamic Font Scaling works in Ionic
. Would this be better suited as info underUsing Dynamic Font Scaling
or a section with info on how the different devices / operating systems handle dynamic scaling?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Our APIs are built on top of the browser behavior, so how Ionic behaves is influenced by the browser behavior which is why I had this section here. I mentioned min/max/clamp because developers potentially will need to use additional CSS to ensure their custom components support Dynamic Font Scaling. I wanted to call it out because developers may think the min/max/clamp behavior is an Ionic bug. This behavior really isn't documented anywhere on the web that I could find.