Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vue): fix bug with key type #3084

Merged
merged 1 commit into from
Aug 14, 2023
Merged

fix(vue): fix bug with key type #3084

merged 1 commit into from
Aug 14, 2023

Conversation

fc92
Copy link
Contributor

@fc92 fc92 commented Aug 13, 2023

Avoid :
Type '{ filepath: string; webviewPath?: string | undefined; }' is not assignable to type 'string | number | symbol | undefined'.ts(2322) runtime-core.d.ts(914, 5): The expected type comes from property 'key' which is declared here on type '{ readonly push?: string | undefined; readonly modelValue?: string | number | boolean | undefined; readonly offset?: string | undefined; readonly offsetLg?: string | undefined; ... 32 more ...; style?: unknown; } & Record<...>' (property) key?: string | number | symbol | undefined

Avoid :
Type '{ filepath: string; webviewPath?: string | undefined; }' is not assignable to type 'string | number | symbol | undefined'.ts(2322)
runtime-core.d.ts(914, 5): The expected type comes from property 'key' which is declared here on type '{ readonly push?: string | undefined; readonly modelValue?: string | number | boolean | undefined; readonly offset?: string | undefined; readonly offsetLg?: string | undefined; ... 32 more ...; style?: unknown; } & Record<...>'
(property) key?: string | number | symbol | undefined
@vercel
Copy link

vercel bot commented Aug 13, 2023

@fc92 is attempting to deploy a commit to the Ionic Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented Aug 14, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ionic-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 14, 2023 7:34pm

Copy link
Contributor

@mapsandapps mapsandapps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! This is a useful fix and matches the docs for React.

@mapsandapps mapsandapps changed the title fix bug with key type fix(vue): fix bug with key type Aug 14, 2023
@mapsandapps mapsandapps merged commit c75a55a into ionic-team:main Aug 14, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants