Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update panasonic-comfort-cloud to 3.0.3 #4269

Closed
wants to merge 1 commit into from
Closed

Conversation

mcm1957
Copy link
Collaborator

@mcm1957 mcm1957 commented Nov 11, 2024

replaement fpr #4266

@github-actions github-actions bot added Stable auto-checked This PR was automatically checked for obvious criterias must be fixed The Adapter request got review/automatic feedback that is required to be fixed before another review labels Nov 11, 2024
Copy link

Automated adapter checker

ioBroker.panasonic-comfort-cloud

Downloads Number of Installations (latest) Number of Installations (stable) - Test and Release
NPM

  • ❗ [E157] js-controller 3.3.22 listed as dependency but 4.0.24 is required as minimum, 5.0.19 is recommended. Please update dependency at io-package.json.
  • ❗ [E254] Version "3.0.3" listed at common.news at io-package.json does not exist at NPM. Please remove from news section.
  • ❗ [E507] missing size attributes [xs,lg,xl] for checkbox at admin/jsonConfig.json/items/automaticRefreshEnabled
  • ❗ [E507] missing size attributes [xs,lg,xl] for number at admin/jsonConfig.json/items/pollinterval
  • ❗ [E507] missing size attributes [xs,lg,xl] for password at admin/jsonConfig.json/items/password
  • ❗ [E507] missing size attributes [xs,lg,xl] for text at admin/jsonConfig.json/items/appVersion
  • ❗ [E507] missing size attributes [xs,lg,xl] for text at admin/jsonConfig.json/items/username
  • ❗ [E510] responsive check: maximum issues reached, please fix reported ones and recheck
  • ❗ [E804] Please process issue [#64] "Compatibility check and testing for node.js 22"
  • 👀 [S526] Consider adding plugin "@alcalzone/release-script-plugin-manual-review".
  • 👀 [W034] @iobroker/adapter-core 3.1.6 specified. 3.2.2 is recommended. Please consider updating dependencies at package.json
  • 👀 [W040] "keywords" within package.json should contain "ioBroker"
  • 👀 [W047] dependency should not require a specific version. Use "~1.2.3" or "^1.2.3" syntax. Please update "panasonic-comfort-cloud-client:2.0.3"
  • 👀 [W252] Version of package.json (3.0.3) doesn't match latest version on NPM (3.0.2)
  • 👀 [W951] .npmignore found but "files" is used at package.json. Please remove .npmignore.

Adapter releases: https://www.iobroker.dev/adapter/panasonic-comfort-cloud/releases
Adapter statistic: https://www.iobroker.dev/adapter/panasonic-comfort-cloud/statistics

History and usage information for release 3.0.2:

3.0.2 created 10.7.2024 (123 days old)
266 users (70.93%)

3.0.2 (stable) created 10.7.2024 (123 days old)
266 users (stable) (70.93%)

Please verify that this PR really tries to update to release 3.0.2!

Add comment "RE-CHECK!" to start check anew

@mcm1957
Copy link
Collaborator Author

mcm1957 commented Nov 11, 2024

@marc2016

Release of 3.0.2 seem to have failed, this release is neither tagged at github nur available at npmjs.
So updateing stable is NOT possible.

image

image

Please fix / reatsrt releasebuild.
And please add node.js 22 tests - this is only a small editing and does not change code of the adapter.

@mcm1957 mcm1957 added the ON HOLD PR is set ON HOLD due to pending question or major issues. label Nov 11, 2024
@mcm1957
Copy link
Collaborator Author

mcm1957 commented Nov 12, 2024

@marc2016

Please create a new PR when problems are fixed, especially when a new release is really available at npm.

@mcm1957 mcm1957 closed this Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-checked This PR was automatically checked for obvious criterias must be fixed The Adapter request got review/automatic feedback that is required to be fixed before another review ON HOLD PR is set ON HOLD due to pending question or major issues. Stable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant