Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cloudless-homeconnect to latest #4214

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

mcm1957
Copy link
Collaborator

@mcm1957 mcm1957 commented Oct 26, 2024

@eifel-tech

Replacement for #4213

@github-actions github-actions bot added the auto-checked This PR was automatically checked for obvious criterias label Oct 26, 2024
@mcm1957 mcm1957 added (RE-)REVIEW pending (mcm1957) Changes requested by review have been applied, re-review could be done. New at LATEST labels Oct 26, 2024
Copy link

github-actions bot commented Oct 26, 2024

ioBroker repository information about New at LATEST tagging

Thanks for spending your time and providing a new adapter for ioBroker.

Your adapter will get a manual review as soon as possible. Please stand by - this might last one or two weeks. Feel free to continue your work and create new releases. You do NOT need to close or update this PR in case of new releases.

In the meantime please check any feedback issues logged by automatic adapter checker and try to fix them. And please check the following information if not yet done:

You will find the results of the review and eventually issues / suggestions as a comment to this PR. So please keep this PR watched.

If you have any urgent questions feel free to ask.

mcm1957

@simatec Please take a look in respect to responsive design. Thanks

@mcm1957
Copy link
Collaborator Author

mcm1957 commented Oct 26, 2024

reminder 2.11.2024

@github-actions github-actions bot added 2.11.2024 remind after 2.11.2024 *📬 a new comment has been added labels Oct 26, 2024
@simatec
Copy link
Contributor

simatec commented Oct 28, 2024

In the jsonConfig I miss some settings for the different screen resolutions.
Here is an example of what it should look like.

"xs": 12,
"sm": 12,
"md": 6,
"lg": 4,
"xl": 4

@eifel-tech
Copy link

@simatec Added the missed screen resolutions and described it at Work in progress section in readme file. This is my first adapter so I wonder if that is enough or do you need a new release now to recheck my code?

@mcm1957
Copy link
Collaborator Author

mcm1957 commented Oct 28, 2024

Thanks for fast response.

Please stand by. @simatec did a dedicated check in respect to responsive UI. I will do a check of code and general behavior as soon as I find some time for it. Maybe some more remarks will occure.

You may create a new release whenever you want, this will not block any checks. But ist not mandatory at this time.

@mcm1957 mcm1957 removed the *📬 a new comment has been added label Oct 28, 2024
Copy link

github-actions bot commented Nov 1, 2024

Automated adapter checker

ioBroker.cloudless-homeconnect

Downloads Number of Installations (latest) - Test and Release
NPM

👍 No errors found

  • 👀 [W401] Cannot find "cloudless-homeconnect" in latest repository

Add comment "RE-CHECK!" to start check anew

@github-actions github-actions bot deleted a comment from mcm1957 Nov 1, 2024
@mcm1957
Copy link
Collaborator Author

mcm1957 commented Nov 5, 2024

Sorry, but due to travel / absence I will nozt able to do the review before ioBroker Meeting Solingen next weekend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.11.2024 remind after 2.11.2024 auto-checked This PR was automatically checked for obvious criterias New at LATEST (RE-)REVIEW pending (mcm1957) Changes requested by review have been applied, re-review could be done.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants