Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update reolink to 1.1.2 #4208

Merged
merged 1 commit into from
Oct 26, 2024
Merged

Update reolink to 1.1.2 #4208

merged 1 commit into from
Oct 26, 2024

Conversation

oelison
Copy link
Contributor

@oelison oelison commented Oct 23, 2024

Please update my adapter ioBroker.reolink to version 1.1.2.

This pull request was created by https://www.iobroker.dev c0726ff.

Copy link

Automated adapter checker

ioBroker.reolink

Downloads Number of Installations (latest) Number of Installations (stable) - Test and Release
NPM

👍 No errors found

Adapter releases: https://www.iobroker.dev/adapter/reolink/releases
Adapter statistic: https://www.iobroker.dev/adapter/reolink/statistics

History and usage information for release 1.1.2:

1.1.2 created 14.9.2024 (38 days old)
227 users (9.34%)

1.1.1 (stable) created 3.8.2024 (80 days old)
1510 users (stable) (62.11%)

Please verify that this PR really tries to update to release 1.1.2!

Add comment "RE-CHECK!" to start check anew

@github-actions github-actions bot added the auto-checked This PR was automatically checked for obvious criterias label Oct 23, 2024
@mcm1957
Copy link
Collaborator

mcm1957 commented Oct 23, 2024

testing with node.js 22 is missing.
please check / mrrge aendue/ioBroker.reolink#117

@mcm1957 mcm1957 added must be fixed The Adapter request got review/automatic feedback that is required to be fixed before another review ON HOLD PR is set ON HOLD due to pending question or major issues. labels Oct 23, 2024
@mcm1957 mcm1957 mentioned this pull request Oct 23, 2024
@oelison
Copy link
Contributor Author

oelison commented Oct 23, 2024

How to set as stable with a change? Make no sense to me.

Not sure how to anderstand your question.

Testings with node 22.js is required. So please add it (or check and merge PR). Testing will not change code of release.

@github-actions github-actions bot added the *📬 a new comment has been added label Oct 23, 2024
@mcm1957 mcm1957 removed the *📬 a new comment has been added label Oct 26, 2024
@oelison
Copy link
Contributor Author

oelison commented Oct 26, 2024

The test for node 22 is now integrated. But a release should create a new version. So there is no change and this could be integrated or not?

@github-actions github-actions bot added the *📬 a new comment has been added label Oct 26, 2024
@mcm1957 mcm1957 removed must be fixed The Adapter request got review/automatic feedback that is required to be fixed before another review ON HOLD PR is set ON HOLD due to pending question or major issues. *📬 a new comment has been added labels Oct 26, 2024
@mcm1957 mcm1957 merged commit 3dfabbe into ioBroker:master Oct 26, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-checked This PR was automatically checked for obvious criterias Stable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants