Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update go-e to 1.0.29 #2996

Merged
merged 1 commit into from
Dec 2, 2023
Merged

Update go-e to 1.0.29 #2996

merged 1 commit into from
Dec 2, 2023

Conversation

MK-2001
Copy link
Contributor

@MK-2001 MK-2001 commented Nov 26, 2023

Push from 1.0.27 to 1.0.29

Push from 1.0.27 to 1.0.29
@github-actions github-actions bot added auto-checked This PR was automatically checked for obvious criterias must be fixed The Adapter request got review/automatic feedback that is required to be fixed before another review Stable labels Nov 26, 2023
@mcm1957 mcm1957 changed the title Update sources-dist-stable.json for go-e Update go-e to 1.0.29 Nov 26, 2023
@mcm1957 mcm1957 added the ON HOLD PR is set ON HOLD due to pending question or major issues. label Nov 26, 2023
@github-actions github-actions bot deleted a comment from mcm1957 Nov 26, 2023
@mcm1957
Copy link
Collaborator

mcm1957 commented Nov 26, 2023

@MK-2001

There are some issues which must be fixed before updating stable revision:

  • please fix issues reported by checker:

    • [E144] common.installedFrom field found in io-package.json. Must be removed.
      Note: no new release is required, fixing the file is sufficient for now.
  • README.md does not include a changelog / revision history. Please add at least the last 5 changes into README.md. See other Adapters or the templates for an example. No new release is required for this fix, it's sufficient if README:md is corrected. Changelog is required at README.md as admin relies on it.

  • It's ok to move older changelogs to an seperated file. Please name this file CHANGELOG_OLD.md and place it at root directory of the adapter. If you are using @AlCalzone/release-script this script can move older changelogs to CHANGELOG_OLD.md automatically. No new release is required for this fix, it's sufficient if file is created / adapted.

  • check and adapt testing

    Standard iobroker testing is required but seems to be missing. Please add and setup ./github/workflows/test-and-release.yml and the corresponding files at /test.

    Tests for node 16 is mandatory unless you require node 18 and higher (at package.json). Tests for node 18 is mandatory as this is the recommended node version and node 16 will be eol and deprected Q3/2023. Consider adding node 20 tests unless you already know incompatibilities.

    So the recommended testmatrix is [16.x, 18.x, 20.x] or [18.x, 20.x] depending on engines requirments setting at package.json

    As node 16 is end-of-life now, it's ok to remove node 16 from testing. In this case please require node 18 as minimum node version at package.json.

    If you need help setting up correct testing, please let us know. I can provide a PR if required.

    No new release is required for this fix, it's sufficient if if tests run successfull with current master/main commit.

  • github dependabot support seems to be missing

    It looks like you did not yet setup dependabot support; at least .github/dependaboit.yml is missing.

    Please consider setting up dependabot support (and to ease life the workflow auto-merge.yml). Dependabot will ensure that your adapter uses the most recent versions of external packages and avoids problem due to outdted base libraries. Dependabit provides PRs at you repository to update the dependencies. Depending on you setting, especially on auto-merge.yml configuration no or only minor revisions will be outmatically merged into you main branch. All major revisions msiut (ans should) be reviewed by you.

    Dependabot support is NOT mandatory, this is only suggestion. But in any case update your dependencies for the next release. axios for example is very outdated, and most likely other dependencies will be too. ioBroker adapter-core needs an update too. But for this release I will not yet consider this blocking.

Please add a comment when you have reviewed and fixed the suggestionsor at least commented the suggestions and you think the adapter is ready for a re-review!

@MK-2001
Copy link
Contributor Author

MK-2001 commented Nov 27, 2023

@mcm1957
Can you please send mit this PR:
If you need help setting up correct testing, please let us know. I can provide a PR if required.
and maybe as well a basic configuration for dependabot.

@github-actions github-actions bot added the *📬 a new comment has been added label Nov 27, 2023
@MK-2001
Copy link
Contributor Author

MK-2001 commented Nov 27, 2023

Closes MK-2001/ioBroker.go-e#179

@github-actions github-actions bot deleted a comment from MK-2001 Nov 27, 2023
@github-actions github-actions bot deleted a comment from MK-2001 Nov 27, 2023
@github-actions github-actions bot deleted a comment from MK-2001 Nov 27, 2023
@github-actions github-actions bot deleted a comment from MK-2001 Nov 27, 2023
@mcm1957
Copy link
Collaborator

mcm1957 commented Nov 27, 2023

@MK-2001
FYI: Its NOT necessary to start repository checks after every check here. You can use the repochecker at www.iobroker.dev too.
I'll provide a PR for testing the next days

@github-actions github-actions bot deleted a comment from MK-2001 Nov 27, 2023
Copy link

Automated adapter checker

ioBroker.go-e

Downloads Number of Installations (latest) Number of Installations (stable)
NPM

👍 No errors found

Adapter releases: https://www.iobroker.dev/adapter/go-e/releases

Adapter statistic: https://www.iobroker.dev/adapter/go-e/statistics

Add comment "RE-CHECK!" to start check anew

@mcm1957 mcm1957 added (RE-)REVIEW pending (mcm1957) Changes requested by review have been applied, re-review could be done. ⚠️check Issue/PR needs attention and removed ON HOLD PR is set ON HOLD due to pending question or major issues. *📬 a new comment has been added labels Nov 27, 2023
@mcm1957
Copy link
Collaborator

mcm1957 commented Dec 2, 2023

PR to adapt testing MK-2001/ioBroker.go-e#201

Please check / merge befor next release.

@mcm1957 mcm1957 removed must be fixed The Adapter request got review/automatic feedback that is required to be fixed before another review (RE-)REVIEW pending (mcm1957) Changes requested by review have been applied, re-review could be done. ⚠️check Issue/PR needs attention labels Dec 2, 2023
@mcm1957 mcm1957 merged commit 1f01f5d into ioBroker:master Dec 2, 2023
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-checked This PR was automatically checked for obvious criterias
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants