Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade wireguard adapter to v1.5.7 #2503

Conversation

Grizzelbee
Copy link
Contributor

fixed typo in icon path (capital G in Grizzelbee) and bumped stable to v1.5.7

Feel free to delay this fix for a few days if you feel uncomfortable with this version.
But ... last real work on this adapter has been some days ago and older versions incl. 1.5.0 are pretty well tested. Rest was to make adapterchecker happy (it's a pitty that you only can test main/master branch and not the current development branch - would make things much easier).

Anyway - from my point of view the adapter is fine for stable.

@github-actions github-actions bot added CHANGES-BOTH-REPOSITORIES auto-checked This PR was automatically checked for obvious criterias must be fixed The Adapter request got review/automatic feedback that is required to be fixed before another review labels Aug 10, 2023
@github-actions
Copy link

Automated adapter checker

ioBroker.wireguard

Downloads Number of Installations (latest) Number of Installations (stable)
NPM

ioBroker.alexa2

Downloads Number of Installations (latest) Number of Installations (stable)
NPM

👍 No errors found

  • 👀 [W171] "common.title" is deprecated in io-package.json
  • 👀 [W105] "common.titleLang" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
  • 👀 [W109] "common.desc" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
  • 👀 [W156] Adapter should support admin 5 UI (jsonConfig) if you do not use a React based UI
  • 👀 [W172] "common.localLink" in io-package.json is deprecated. Please define object "common.localLinks": { "_default": "..." }

ioBroker.pixelit

Downloads Number of Installations (latest) Number of Installations (stable)
NPM

👍 No errors found

ioBroker.seq

Downloads Number of Installations (latest) Number of Installations (stable)
NPM

👍 No errors found

  • 👀 [W156] Adapter should support admin 5 UI (jsonConfig) if you do not use a React based UI

Add comment "RE-CHECK!" to start check anew

@mcm1957
Copy link
Collaborator

mcm1957 commented Aug 10, 2023

1.5.7 created 10.8.
1.5.1 created 8.8.

@mcm1957 mcm1957 added STABLE - brand new and removed must be fixed The Adapter request got review/automatic feedback that is required to be fixed before another review labels Aug 10, 2023
@Apollon77
Copy link
Collaborator

it's a pitty that you only can test main/master branch and not the current development branch - would make things much easier

hhm. ... DO you know https://adapter-check.iobroker.in/ ... !? There you can set the branch name too ....

@Grizzelbee
Copy link
Contributor Author

hhm. ... DO you know https://adapter-check.iobroker.in/ ... !? There you can set the branch name too ....

Nope. Not aware that there are two versions of the adapter checker. I know that there was a standalone version before developer portal exists, but always thought the one in the portal is only a shortcut to this one - so I deleted my shortcuts to the stand alone version. A hint in dev portal that there is a more powerful version out there wouldt be very appreciated.

@Grizzelbee
Copy link
Contributor Author

I withdraw this PR. Some unexpected behaviour under seldom circumstances has been found today - but it's pretty easy to fix, so I do it quickly. Therefor I close this PR and open a new one to fix the the icon-path and in a few days a second one for the new stable.

It's the same thing every time: it's a bad idea to mix things up - I should have kown it. Sorry for this - but for me it was worth it to get the information with the two adatper checkers.

@Grizzelbee Grizzelbee closed this Aug 11, 2023
@mcm1957
Copy link
Collaborator

mcm1957 commented Aug 11, 2023

hhm. ... DO you know https://adapter-check.iobroker.in/ ... !? There you can set the branch name too ....

Nope. Not aware that there are two versions of the adapter checker. I know that there was a standalone version before developer portal exists, but always thought the one in the portal is only a shortcut to this one - so I deleted my shortcuts to the stand alone version. A hint in dev portal that there is a more powerful version out there wouldt be very appreciated.

No - there aren't multiple checkers. There are only different ways to activate the one and only checker :-)

https://adapter-check.iobroker.in/
https://www.iobroker.dev
https://github.com/ioBroker/ioBroker.repochecker

I never had the need to use another branch than main/master. But your need is justified. I will add a feature request for the dev portal. but do not expect a fast change as developers who can do even small things at frontend are rare.

@Grizzelbee
Copy link
Contributor Author

I never had the need to use another branch than main/master.

Since the main/master branch is directly the beta/unstable version to iobroker - I always do my work in a development branch and only merge it to the main branch when it's working so far and I think it's fine for testing - and in that case I have to provide a version number, npm package and so on. But after doing so this version number and package are burned. Just like in my case this time - multiple times. Therefore it's very useful to run the adapter checker on the current development branch - esp. when some time has passed since the last development and new checks have been added to the checker - which need to be fixed; best before going to beta!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-checked This PR was automatically checked for obvious criterias
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants