Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fallback to own request module #1650

Merged
merged 1 commit into from
Jul 27, 2024
Merged

fallback to own request module #1650

merged 1 commit into from
Jul 27, 2024

Conversation

foxriver76
Copy link
Contributor

@foxriver76 foxriver76 merged commit 57299d9 into master Jul 27, 2024
7 checks passed
@foxriver76 foxriver76 deleted the issue-1649 branch July 27, 2024 11:08
@klein0r
Copy link
Collaborator

klein0r commented Jul 27, 2024

With that solution, suncalc2 will be the next issue (suncalc is mapped by default to suncalc2)

suncalc: require('suncalc2'),

"suncalc2": "^1.8.1",

@foxriver76
Copy link
Contributor Author

If all these modules are just there for being provided by default and not used by javascript directly (idk?) then we should maybe just push them to the list of additional node modules @klein0r

@klein0r
Copy link
Collaborator

klein0r commented Jul 27, 2024

suncalc2 is used by javascript directly. But a lot of users built their own scripts and require that module.

@foxriver76
Copy link
Contributor Author

hm yes then a list instead of just request hardcoded? If you have an overview it would be great if you could provide a list or even implement the changes. Or really in the catch try it without the adapter identifier..

@klein0r
Copy link
Collaborator

klein0r commented Jul 27, 2024

Or really in the catch try it without the adapter identifier..

I would prefer that. Sounds like a good fallback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: request funktioniert nicht mehr
3 participants