Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependencies #401

Merged
merged 2 commits into from
Oct 25, 2024
Merged

Update dependencies #401

merged 2 commits into from
Oct 25, 2024

Conversation

notaphplover
Copy link
Member

Description

  • Updated dependencies.

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@notaphplover notaphplover self-assigned this Oct 25, 2024
@notaphplover notaphplover merged commit 0a44725 into master Oct 25, 2024
4 checks passed
@notaphplover notaphplover deleted the chore/update-dependencies branch October 25, 2024 11:02
PodaruDragos
PodaruDragos reviewed Oct 25, 2024
View reviewed changes
package.json
@@ -6,28 +6,28 @@
"dependencies": {
"express": "4.18.2",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we just upgrade to 5 ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so, the version tagged as lateston npm is 4.21.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PodaruDragos PodaruDragos PodaruDragos left review comments

Assignees

@notaphplover notaphplover

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@notaphplover @PodaruDragos