Testing Up to 100%

[robertrico]

Brought Testing up to 100% Code Coverage
Removed Console Log
New Lines

The code coverage in the current state was not 100%. To start contributing I thought it'd be good to get this brought to 100% while investing deeper into the codebase.

Description

• Tested LazyServiceIdentifier unwrap call.
• Tested unwrap LazyServiceIdentifier in getConstructorArgsAsTarget
• Removed Console Log in resolver test
• Tested the asynchronous unbinds for PromiseLike singletons
• Tested getNamed on binding factory
• Tested null binding contraint whenTargetIsDefault is called

Related Issue

#1426

Motivation and Context

Getting my feet wet in contributing to InversifyJS. My team and I use this in our production platform and I would like to have more insight, knowledge and better knowing this core feature stays up to date.

How Has This Been Tested?

Ran npm test over and over and over. Scanned for es-lint errors and made sure coverage was 100% in nyc HTML code coverage page.

Types of changes

• Updated docs / Refactor code / Added a tests case (non-breaking change)
• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• All new and existing tests passed.
• I have updated the changelog.

[codecov-commenter]

Codecov Report

Merging #1443 (5efd4a6) into master (715a3f9) will increase coverage by 0.58%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1443      +/-   ##
==========================================
+ Coverage   99.26%   99.85%   +0.58%     
==========================================
  Files          53       53              
  Lines        1367     1367              
  Branches      192      192              
==========================================
+ Hits         1357     1365       +8     
+ Misses          5        0       -5     
+ Partials        5        2       -3     

Impacted Files	Coverage Δ
src/container/container.ts	100.00% <0.00%> (+0.76%)	⬆️
src/syntax/binding_to_syntax.ts	100.00% <0.00%> (+1.88%)	⬆️
src/planning/reflection_utils.ts	100.00% <0.00%> (+2.27%)	⬆️
src/syntax/binding_when_syntax.ts	100.00% <0.00%> (+4.08%)	⬆️
src/annotation/lazy_service_identifier.ts	100.00% <0.00%> (+33.33%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 715a3f9...5efd4a6. Read the comment docs.

[PodaruDragos]

LGTM. Thanks for doing this.

FYI we had a talk where we wanted to move everything to jest.
Are you interested in that port ?

I'll merge this regardless.