Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup modals #8432

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

SchrodingersGat
Copy link
Member

  • Tweaks / improvements for system information modals

@SchrodingersGat SchrodingersGat added user interface User interface refactor Platform UI Related to the React based User Interface labels Nov 5, 2024
@SchrodingersGat SchrodingersGat added this to the 0.17.0 milestone Nov 5, 2024
Copy link

netlify bot commented Nov 5, 2024

Deploy Preview for inventree-web-pui-preview ready!

Name Link
🔨 Latest commit e4d7826
🔍 Latest deploy log https://app.netlify.com/sites/inventree-web-pui-preview/deploys/672a8adf619cba0008f3e9d3
😎 Deploy Preview https://deploy-preview-8432--inventree-web-pui-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 99 (🔴 down 1 from production)
Accessibility: 86 (no change from production)
Best Practices: 100 (no change from production)
SEO: 78 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Nov 5, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Project coverage is 84.38%. Comparing base (b4310bf) to head (e4d7826).
Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
...rc/frontend/src/components/modals/LicenseModal.tsx 85.71% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8432      +/-   ##
==========================================
- Coverage   84.47%   84.38%   -0.10%     
==========================================
  Files        1170     1170              
  Lines       53456    53464       +8     
  Branches     1999     2003       +4     
==========================================
- Hits        45159    45115      -44     
- Misses       7769     7834      +65     
+ Partials      528      515      -13     
Flag Coverage Δ
pui 68.01% <87.50%> (-0.52%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Platform UI Related to the React based User Interface refactor user interface User interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants