-
-
Notifications
You must be signed in to change notification settings - Fork 772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve optional chaining checks #8431
Conversation
SchrodingersGat
commented
Nov 5, 2024
- Fixes bug where part_detail is potentially undefined
- Fixes bug where part_detail is potentially undefined
✅ Deploy Preview for inventree-web-pui-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8431 +/- ##
==========================================
- Coverage 84.40% 84.34% -0.06%
==========================================
Files 1170 1170
Lines 53459 53459
Branches 2002 2002
==========================================
- Hits 45120 45091 -29
- Misses 7823 7854 +31
+ Partials 516 514 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm; solves a few warnings from the sast too