Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve optional chaining checks #8431

Merged
merged 3 commits into from
Nov 5, 2024

Conversation

SchrodingersGat
Copy link
Member

  • Fixes bug where part_detail is potentially undefined

- Fixes bug where part_detail is potentially undefined
@SchrodingersGat SchrodingersGat added bug Identifies a bug which needs to be addressed user interface User interface Platform UI Related to the React based User Interface labels Nov 5, 2024
@SchrodingersGat SchrodingersGat added this to the 0.17.0 milestone Nov 5, 2024
Copy link

netlify bot commented Nov 5, 2024

Deploy Preview for inventree-web-pui-preview ready!

Name Link
🔨 Latest commit 64b73d9
🔍 Latest deploy log https://app.netlify.com/sites/inventree-web-pui-preview/deploys/672a227d841d76000868e678
😎 Deploy Preview https://deploy-preview-8431--inventree-web-pui-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 99 (🔴 down 1 from production)
Accessibility: 86 (no change from production)
Best Practices: 100 (no change from production)
SEO: 78 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Nov 5, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 84.34%. Comparing base (7b640a4) to head (64b73d9).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/frontend/src/forms/StockForms.tsx 0.00% 4 Missing ⚠️
src/frontend/src/forms/PurchaseOrderForms.tsx 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8431      +/-   ##
==========================================
- Coverage   84.40%   84.34%   -0.06%     
==========================================
  Files        1170     1170              
  Lines       53459    53459              
  Branches     2002     2002              
==========================================
- Hits        45120    45091      -29     
- Misses       7823     7854      +31     
+ Partials      516      514       -2     
Flag Coverage Δ
pui 67.80% <0.00%> (-0.31%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@matmair matmair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm; solves a few warnings from the sast too

@SchrodingersGat SchrodingersGat merged commit f470d30 into inventree:master Nov 5, 2024
26 checks passed
@SchrodingersGat SchrodingersGat deleted the pui-fixes branch November 5, 2024 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Identifies a bug which needs to be addressed Platform UI Related to the React based User Interface user interface User interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants