Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix for plugin table #8411

Merged
merged 1 commit into from
Nov 2, 2024

Conversation

SchrodingersGat
Copy link
Member

  • Allow "deactivation" of missing plugin
  • Required before it can be deleted

- Allow "deactivation" of missing plugin
- Required before it can be deleted
@SchrodingersGat SchrodingersGat added bug Identifies a bug which needs to be addressed plugin Plugin ecosystem Platform UI Related to the React based User Interface labels Nov 2, 2024
@SchrodingersGat SchrodingersGat added this to the 0.17.0 milestone Nov 2, 2024
Copy link

netlify bot commented Nov 2, 2024

Deploy Preview for inventree-web-pui-preview ready!

Name Link
🔨 Latest commit 43ed51a
🔍 Latest deploy log https://app.netlify.com/sites/inventree-web-pui-preview/deploys/672621d74e86b4000884ff26
😎 Deploy Preview https://deploy-preview-8411--inventree-web-pui-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (no change from production)
Accessibility: 86 (no change from production)
Best Practices: 100 (no change from production)
SEO: 78 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Nov 2, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 84.47%. Comparing base (6cca66c) to head (43ed51a).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
src/frontend/src/tables/plugin/PluginListTable.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8411      +/-   ##
==========================================
+ Coverage   84.42%   84.47%   +0.05%     
==========================================
  Files        1170     1170              
  Lines       53398    53398              
  Branches     1996     1996              
==========================================
+ Hits        45079    45107      +28     
+ Misses       7807     7767      -40     
- Partials      512      524      +12     
Flag Coverage Δ
pui 68.23% <0.00%> (+0.29%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SchrodingersGat SchrodingersGat merged commit 4308f0c into inventree:master Nov 2, 2024
28 of 29 checks passed
@SchrodingersGat SchrodingersGat deleted the plugin-admin branch November 2, 2024 13:22
@wolflu05
Copy link
Contributor

wolflu05 commented Nov 2, 2024

Is that the bug that a plugin could sometimes not directly be activated after installing it because something weird is in the browser cache?

@SchrodingersGat
Copy link
Member Author

No, that must be a different thing?

@wolflu05
Copy link
Contributor

wolflu05 commented Nov 2, 2024

ok, thats a really strange one, because I cannot reproduce it every time. But maybe that's already fixed. Ill see if I see it sometime again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Identifies a bug which needs to be addressed Platform UI Related to the React based User Interface plugin Plugin ecosystem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants