Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PUI] Table refactor #8395

Merged
merged 11 commits into from
Oct 31, 2024
Merged

Conversation

SchrodingersGat
Copy link
Member

  • Split table header component into different file, for better maintainability
  • Add option to remove header entirely

@SchrodingersGat SchrodingersGat added user interface User interface refactor Platform UI Related to the React based User Interface labels Oct 30, 2024
@SchrodingersGat SchrodingersGat added this to the 0.17.0 milestone Oct 30, 2024
Copy link

netlify bot commented Oct 30, 2024

Deploy Preview for inventree-web-pui-preview ready!

Name Link
🔨 Latest commit 5c41601
🔍 Latest deploy log https://app.netlify.com/sites/inventree-web-pui-preview/deploys/672381e41efaa2000825685a
😎 Deploy Preview https://deploy-preview-8395--inventree-web-pui-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (no change from production)
Accessibility: 86 (no change from production)
Best Practices: 100 (no change from production)
SEO: 78 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Oct 30, 2024

Codecov Report

Attention: Patch coverage is 52.00000% with 36 lines in your changes missing coverage. Please review.

Project coverage is 84.29%. Comparing base (913a05c) to head (5c41601).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
src/frontend/src/tables/InvenTreeTableHeader.tsx 41.86% 21 Missing and 4 partials ⚠️
src/frontend/src/tables/InvenTreeTable.tsx 62.96% 8 Missing and 2 partials ⚠️
src/frontend/src/hooks/UseTable.tsx 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8395      +/-   ##
==========================================
- Coverage   84.39%   84.29%   -0.11%     
==========================================
  Files        1167     1168       +1     
  Lines       53230    53249      +19     
  Branches     1972     1978       +6     
==========================================
- Hits        44923    44885      -38     
- Misses       7814     7874      +60     
+ Partials      493      490       -3     
Flag Coverage Δ
backend 85.98% <100.00%> (+<0.01%) ⬆️
pui 67.29% <51.35%> (-0.56%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@matmair matmair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good; it seems that the header less feature was not used - is that planned in this PR?

@SchrodingersGat
Copy link
Member Author

Looks good; it seems that the header less feature was not used - is that planned in this PR?

Not actually used yet, but planning to implement some "sub tables" (once I can get nested tables working)

@SchrodingersGat SchrodingersGat merged commit 871cd90 into inventree:master Oct 31, 2024
26 checks passed
@SchrodingersGat SchrodingersGat deleted the table-refactor branch October 31, 2024 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Platform UI Related to the React based User Interface refactor user interface User interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants