-
-
Notifications
You must be signed in to change notification settings - Fork 772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PUI] Table refactor #8395
[PUI] Table refactor #8395
Conversation
SchrodingersGat
commented
Oct 30, 2024
- Split table header component into different file, for better maintainability
- Add option to remove header entirely
✅ Deploy Preview for inventree-web-pui-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8395 +/- ##
==========================================
- Coverage 84.39% 84.29% -0.11%
==========================================
Files 1167 1168 +1
Lines 53230 53249 +19
Branches 1972 1978 +6
==========================================
- Hits 44923 44885 -38
- Misses 7814 7874 +60
+ Partials 493 490 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good; it seems that the header less feature was not used - is that planned in this PR?
Not actually used yet, but planning to implement some "sub tables" (once I can get nested tables working) |
- Revert to proper panels