Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove coupling of tests to cui #8389

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

matmair
Copy link
Member

@matmair matmair commented Oct 28, 2024

This PR upstreames changes from #8384 that can be taken now to decouple tests (and remove unneeded warnings)

Copy link

netlify bot commented Oct 28, 2024

Deploy Preview for inventree-web-pui-preview canceled.

Name Link
🔨 Latest commit e9ba350
🔍 Latest deploy log https://app.netlify.com/sites/inventree-web-pui-preview/deploys/67292e9d039a420008f15f61

Copy link

codecov bot commented Nov 4, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 84.35%. Comparing base (b4310bf) to head (e9ba350).

Files with missing lines Patch % Lines
src/backend/InvenTree/InvenTree/test_middleware.py 77.77% 2 Missing ⚠️
src/backend/InvenTree/build/tests.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8389      +/-   ##
==========================================
- Coverage   84.47%   84.35%   -0.13%     
==========================================
  Files        1170     1168       -2     
  Lines       53456    52992     -464     
  Branches     1999     1882     -117     
==========================================
- Hits        45159    44703     -456     
- Misses       7769     7817      +48     
+ Partials      528      472      -56     
Flag Coverage Δ
backend 85.84% <75.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant