-
-
Notifications
You must be signed in to change notification settings - Fork 772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to zoneinfo from pytz #7645
base: master
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for inventree-web-pui-preview canceled.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7645 +/- ##
==========================================
+ Coverage 83.52% 84.25% +0.72%
==========================================
Files 1114 1105 -9
Lines 49355 48854 -501
Branches 1571 1440 -131
==========================================
- Hits 41225 41162 -63
+ Misses 7734 7314 -420
+ Partials 396 378 -18
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Nice. Should we also remove pytz from the requirements? |
@SchrodingersGat sadly not, some of our dependencies still depend on it |
I need to figure out why CI works on my machine but not on GH |
This is more complex than initially thought. https://blog.ganssle.io/articles/2018/03/pytz-fastest-footgun.html |
Wow, what a deep dive! |
We target 3.9 which has zoneinfo for timezone info instead of pytz.