Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to zoneinfo from pytz #7645

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Conversation

matmair
Copy link
Member

@matmair matmair commented Jul 13, 2024

We target 3.9 which has zoneinfo for timezone info instead of pytz.

@matmair matmair added security Relates to a security issue refactor labels Jul 13, 2024
@matmair matmair added this to the 0.16.0 milestone Jul 13, 2024
@matmair matmair self-assigned this Jul 13, 2024
Copy link

netlify bot commented Jul 13, 2024

Deploy Preview for inventree-web-pui-preview canceled.

Name Link
🔨 Latest commit 3e7a3b6
🔍 Latest deploy log https://app.netlify.com/sites/inventree-web-pui-preview/deploys/66a95a21ec85070008da3a80

Copy link

codecov bot commented Jul 13, 2024

Codecov Report

Attention: Patch coverage is 77.77778% with 2 lines in your changes missing coverage. Please review.

Project coverage is 84.25%. Comparing base (637a7fe) to head (3e7a3b6).
Report is 9 commits behind head on master.

Files Patch % Lines
src/backend/InvenTree/InvenTree/helpers.py 60.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7645      +/-   ##
==========================================
+ Coverage   83.52%   84.25%   +0.72%     
==========================================
  Files        1114     1105       -9     
  Lines       49355    48854     -501     
  Branches     1571     1440     -131     
==========================================
- Hits        41225    41162      -63     
+ Misses       7734     7314     -420     
+ Partials      396      378      -18     
Flag Coverage Δ
backend 85.33% <77.77%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SchrodingersGat
Copy link
Member

Nice. Should we also remove pytz from the requirements?

@matmair
Copy link
Member Author

matmair commented Jul 14, 2024

@SchrodingersGat sadly not, some of our dependencies still depend on it

@matmair matmair marked this pull request as draft July 17, 2024 16:34
@matmair
Copy link
Member Author

matmair commented Jul 17, 2024

I need to figure out why CI works on my machine but not on GH

@matmair
Copy link
Member Author

matmair commented Jul 30, 2024

This is more complex than initially thought. https://blog.ganssle.io/articles/2018/03/pytz-fastest-footgun.html
I am amazed we have not had problems with pytz before.

@matmair matmair modified the milestones: 0.16.0, 1.0.0 Jul 30, 2024
@SchrodingersGat
Copy link
Member

Wow, what a deep dive!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor security Relates to a security issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants