Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mantine charts #7419

Merged
merged 14 commits into from
Jun 9, 2024
Merged

Conversation

SchrodingersGat
Copy link
Member

Refactor pricing charts to use new @mantine/charts library.

@SchrodingersGat SchrodingersGat added user interface User interface refactor Platform UI Related to the React based User Interface labels Jun 8, 2024
@SchrodingersGat SchrodingersGat added this to the 0.16.0 milestone Jun 8, 2024
Copy link

netlify bot commented Jun 8, 2024

Deploy Preview for inventree-web-pui-preview ready!

Name Link
🔨 Latest commit cf19e71
🔍 Latest deploy log https://app.netlify.com/sites/inventree-web-pui-preview/deploys/666557d5c88a850008ba5c01
😎 Deploy Preview https://deploy-preview-7419--inventree-web-pui-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (🟢 up 1 from production)
Accessibility: 89 (no change from production)
Best Practices: 92 (no change from production)
SEO: 70 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Jun 8, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 83.87%. Comparing base (9f35971) to head (cf19e71).
Report is 336 commits behind head on master.

Files with missing lines Patch % Lines
...rontend/src/components/charts/tooltipFormatter.tsx 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7419      +/-   ##
==========================================
- Coverage   83.91%   83.87%   -0.04%     
==========================================
  Files        1057     1056       -1     
  Lines       46414    46328      -86     
  Branches     1393     1386       -7     
==========================================
- Hits        38946    38857      -89     
- Misses       7092     7109      +17     
+ Partials      376      362      -14     
Flag Coverage Δ
pui 65.89% <90.00%> (-0.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@matmair matmair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; the tests might need adjusting

@SchrodingersGat SchrodingersGat merged commit 713d2ac into inventree:master Jun 9, 2024
27 checks passed
@SchrodingersGat SchrodingersGat deleted the mantine-charts branch June 9, 2024 22:24
martonmiklos pushed a commit to martonmiklos/InvenTree that referenced this pull request Jun 24, 2024
* Install @mantine/charts

* Import charts styles

* Refactor <PricingOverviewPanel />

* Refactor internal price panel

* Refactor variant price panel

* BOM bar chart

* BOM donut

* Refactor supplier pricing panel

* More refaactoring

* Cleanup unused imports

* Fix typo

* playwright test updates
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Platform UI Related to the React based User Interface refactor user interface User interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants