Skip to content
This repository has been archived by the owner on May 3, 2020. It is now read-only.

WIP global: javascript restructuring #64

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

WIP global: javascript restructuring #64

wants to merge 2 commits into from

Conversation

mvesper
Copy link
Contributor

@mvesper mvesper commented Jan 16, 2017

  • Cleans the current javascript folder structure.

@mvesper
global: item revision endpoint
12a5e36 
* Adds the endpoint configuration for `Item.find_by_holding`.

Signed-off-by: Martin Vesper <[email protected]>
@mvesper
global: javascript restructuring
0d9ca36 
* Cleans the current javascript folder structure.
drjova
drjova reviewed Jan 18, 2017
View reviewed changes
invenio_circulation/static/js/circulation/circulation_admin/directives/circulationItemBasket.js
scope.remove = remove;
scope.loan = loan;
scope.request = request;
scope.return = returnItem;
Copy link

@drjova drjova Jan 18, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a tiny thing, it is better to set the scope after the functions' definition :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@drjova drjova drjova approved these changes

Assignees

@mvesper mvesper

Labels
Status: in review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mvesper @drjova @jirikuncar @david-caro