Add ToC icon display if enableChaptersPlugin (#1289)

* add ToC icon display if enableChaptersPlugin * update tests
internetarchive · Dec 19, 2023 · fd083e7 · fd083e7
1 parent a6beb85
commit fd083e7
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 5 deletions.
diff --git a/src/BookNavigator/book-navigator.js b/src/BookNavigator/book-navigator.js
@@ -67,6 +67,7 @@ export class BookNavigator extends LitElement {
        * sets exit FS button (`this.fullscreenBranding1)
        * when `br.options.enableFSLogoShortcut`
        */
+      'chapters',
       'fullscreen',
       'volumes',
       'search',
@@ -359,7 +360,6 @@ export class BookNavigator extends LitElement {
     }
 
     this.menuShortcuts.push(this.menuProviders[menuId]);
-
     this.sortMenuShortcuts();
     this.emitMenuShortcutsUpdated();
   }

diff --git a/src/plugins/plugin.chapters.js b/src/plugins/plugin.chapters.js
@@ -76,6 +76,7 @@ BookReader.prototype._chaptersRender = function() {
     }}"
     />`,
   };
+  shell.addMenuShortcut('chapters');
   shell.updateMenuContents();
   this._tocEntries.forEach((tocEntry, i) => this._chaptersRenderMarker(tocEntry, i));
 };

diff --git a/tests/jest/BookNavigator/book-navigator.test.js b/tests/jest/BookNavigator/book-navigator.test.js
@@ -320,10 +320,13 @@ describe('<book-navigator>', () => {
       describe('Shortcuts', () => {
         test('has specific order of menu shortcuts to show', () => {
           const el = fixtureSync(container());
-          expect(el.shortcutOrder[0]).toEqual('fullscreen');
-          expect(el.shortcutOrder[1]).toEqual('volumes');
-          expect(el.shortcutOrder[2]).toEqual('search');
-          expect(el.shortcutOrder[3]).toEqual('bookmarks');
+          expect(el.shortcutOrder).toEqual([
+            'chapters',
+            'fullscreen',
+            'volumes',
+            'search',
+            'bookmarks'
+          ]);
         });
       });
 

diff --git a/tests/jest/plugins/plugin.chapters.test.js b/tests/jest/plugins/plugin.chapters.test.js
@@ -157,11 +157,13 @@ describe("BRChaptersPlugin", () => {
         _chaptersRenderMarker: sinon.stub(),
         shell: {
           menuProviders: {},
+          addMenuShortcut: sinon.stub(),
           updateMenuContents: sinon.stub(),
         }
       };
       BookReader.prototype._chaptersRender.call(fakeBR);
       expect(fakeBR.shell.menuProviders['chapters']).toBeTruthy();
+      expect(fakeBR.shell.addMenuShortcut.callCount).toBe(1);
       expect(fakeBR.shell.updateMenuContents.callCount).toBe(1);
       expect(fakeBR._chaptersRenderMarker.callCount).toBeGreaterThan(1);
     });