Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(auth): use expires_in in grant initiation response body #783

Merged
merged 2 commits into from
Nov 23, 2022
Merged

fix(auth): use expires_in in grant initiation response body #783

merged 2 commits into from
Nov 23, 2022

Conversation

wilsonianb
Copy link
Contributor

@wilsonianb wilsonianb commented Nov 23, 2022 •
edited
Loading

Changes proposed in this pull request

Context

Checklist

  • Related issues linked using fixes #number
  • Tests added/updated
  • Documentation added
  • Make sure that all checks pass

@github-actions github-actions bot added pkg: auth Changes in the GNAP auth package. pkg: open-payments type: source Changes business logic type: tests Testing related labels Nov 23, 2022
@wilsonianb wilsonianb marked this pull request as ready for review November 23, 2022 14:28
mkurapov
mkurapov requested changes Nov 23, 2022
View reviewed changes
Copy link
Contributor

@mkurapov mkurapov left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to update the AS token rotation response as well

nvm, I was looking at the access token service not the routes. In the accessTokenRoutes we return expires_at correctly

@wilsonianb wilsonianb merged commit 5a19201 into main Nov 23, 2022
@wilsonianb wilsonianb deleted the bw-expires-in branch November 23, 2022 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkurapov mkurapov mkurapov approved these changes

@njlie njlie Awaiting requested review from njlie

Assignees
No one assigned
Labels
pkg: auth Changes in the GNAP auth package. type: source Changes business logic type: tests Testing related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix grant initiation response body
2 participants
@wilsonianb @mkurapov