Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spec: add user and subject information to grant request/response #504

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sabineschaller
Copy link
Member

Changes proposed in this pull request

As discussed during the Open Payments call, I added the user and subject objects to the grant request and just the subject object to the grant response.

I'm not sure that subject is actually required, because in a first step, we don't want to request subject information but rather just identify the user. But we can discuss on here or on a call.

Context

Copy link

changeset-bot bot commented Oct 7, 2024

⚠️ No Changeset found

Latest commit: 3cee721

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

netlify bot commented Oct 7, 2024

Deploy Preview for openpayments-preview canceled.

Name Link
🔨 Latest commit 3cee721
🔍 Latest deploy log https://app.netlify.com/sites/openpayments-preview/deploys/6703fff535b6ce00086707ea

@@ -134,8 +187,22 @@ paths:
- read
identifier: 'http://ilp.rafiki.money/bob'
client: 'https://webmonize.com/.well-known/pay'
Indentifying the user:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: misspelling of "Identifying"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants