feat(open-payments): make schema validation in the open-payments client behind a flag #467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… openapi schema validation
… disable openapi schema validation" This reverts commit b5f986a. # Conflicts: # packages/open-payments/src/client/requests.test.ts # packages/open-payments/src/client/requests.ts
# Conflicts: # .github/workflows/env-setup/action.yaml
…bal setup" This reverts commit 9285d60.
… openapi schema validation # Conflicts: # packages/open-payments/src/client/requests.test.ts # packages/open-payments/src/client/requests.ts
🦋 Changeset detectedLatest commit: 3ec839d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
mkurapov
changed the title
mkurapov
commented
Apr 29, 2024
| @@ -129,6 +130,7 @@ const parseKey = ( | |||
|
|
|||
| const createUnauthenticatedDeps = async ({ | |||
| useHttp = false, | |||
| validateResponses = true, | |||
There was a problem hiding this comment.
the main change here: the addition of optional validateResponses flag when creating the open payments clients.
3 tasks
✅ Deploy Preview for openpayments-preview canceled.
|
# Conflicts: # packages/open-payments/src/client/requests.ts
mkurapov
force-pushed
the
454/mk/optional-schema-validation
branch
from
80c0037
to
28805f9
Compare
mkurapov
force-pushed
the
454/mk/optional-schema-validation
branch
from
1f74dc9
to
865b6c5
Compare
BlairCurrey
approved these changes
May 1, 2024
|
Tested in the browser with the extension, I do not see any errors related to the client initialization. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
Context
This change adds
validateResponsesflag to open payments client initialization function. This allows bypassing runtime response validation against the Open Payments OpenAPI specs.This is particularly useful for the WM extension use case since the openapi validator libraries we use under the hood in @interledger/openapi use
ajvschema validation during runtime, which uses unsafeeval, and as a result, prevents us from running it in the extension for manifest v3: ajv-validator/ajv#406.Fixes #454