-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(open-payments): export OpenAPI specs #440
Conversation
🦋 Changeset detectedLatest commit: 083719f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for openpayments-preview canceled.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Will be nice to have an easier way to get the right spec version in rafiki.
I spent some time thinking about the path assertions in packages/open-payments/src/openapi/index.test.ts
. I was just thinking they were more a concern of createOpenAPI
(if anything - kinda just an implementation detail of the spec) but I suppose it makes sense as a sanity check and isn't hard to update when things change (and they dont change often).
@BlairCurrey good point, I was thinking along the same lines, but like you said, this is sanity checking |
@BlairCurrey also, what was cool is that I just pnpm-linked the package with the changes and ran it through your integration test as a sanity in Rafiki 👍 |
Changes proposed in this pull request
getAuthServerOpenAPI
getResourceServerOpenAPI
getWalletAddressServerOpenAPI
functions from theopen-payments
packageopenapi/*yaml
files intoopenapi/specs/
Context
Since we bundle the yaml files with the
open-payments
package, we should let users of the package (importantly for us, Rafiki) to fetch theOpenAPI
objects for the Open Payments specsFixes #439