Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README.md #3

Merged
merged 5 commits into from
Jun 24, 2024
Merged

Update README.md #3

merged 5 commits into from
Jun 24, 2024

Conversation

Tymmmy
Copy link
Contributor

@Tymmmy Tymmmy commented Apr 17, 2024

No description provided.

@Tymmmy Tymmmy self-assigned this Apr 17, 2024
@Tymmmy Tymmmy linked an issue Apr 17, 2024 that may be closed by this pull request
Update Readme for ILPay #2
Closed
raducristianpopa
raducristianpopa reviewed Apr 18, 2024
View reviewed changes
Copy link
Member

@raducristianpopa raducristianpopa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add a.env.example file with default values. For PRIVATE_KEY, KEY_ID and WALLET_ADDRESS we should have a small explanatory section.

package.json Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@Tymmmy Tymmmy merged commit 595504b into main Jun 24, 2024
3 checks passed
@Tymmmy Tymmmy deleted the 2-update-readme-for-ilpay branch June 24, 2024 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lengyel-arpad85 lengyel-arpad85 lengyel-arpad85 approved these changes

@raducristianpopa raducristianpopa Awaiting requested review from raducristianpopa

@dragosp1011 dragosp1011 Awaiting requested review from dragosp1011

Assignees

@Tymmmy Tymmmy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Readme for ILPay
3 participants
@Tymmmy @raducristianpopa @lengyel-arpad85