Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add external_id to Contact model #287

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

al3x3i
Copy link

@al3x3i al3x3i commented Sep 30, 2020

Why?

Add external_id because API 2.2 supports it.

How?

Allows have different Contacts with the same email.

@al3x3i
Copy link
Author

al3x3i commented Sep 30, 2020

Fixes: #286

@narenlog
Copy link

narenlog commented Nov 8, 2022

Hi ! lot of us are waiting to query contact based on external_id which is the userID from the User object which is not available anymore.

In any case, external_id is the unique identifier when we have multiple contacts with the same email.
You can see from the forum posts how important it is to query external_id

Please review and merge please.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants