Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conversation message fixes #252

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation message fixes #252

wants to merge 2 commits into from

Conversation

lukas-krecan-lt
Copy link

Why?

I need to see real type of the conversation message and delivered_as field

How?

See the PR

@lukas-krecan-lt
Adding real type of conversation message
5ac50dd 
I was afraid to change the “type” field since it would have been backward incompatible change
alexshultsg
alexshultsg suggested changes Nov 11, 2019
View reviewed changes
Copy link
Contributor

@alexshultsg alexshultsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't you also need to update superclass overrides?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexshultsg alexshultsg alexshultsg approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lukas-krecan-lt @alexshultsg