Add conversation participants support #241
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thewheat
commented
Oct 28, 2018
| @@ -178,7 +183,7 @@ private HttpURLConnection initializeConnection(URI uri, String method) throws IO | |||
| } | |||
|
|
|||
| private boolean shouldSkipResponseEntity(JavaType javaType, HttpURLConnection conn, int responseCode) { | |||
| return responseCode == 204 || Void.class.equals(javaType.getRawClass()) || "DELETE".equals(conn.getRequestMethod()); | |||
| return responseCode == 204 || Void.class.equals(javaType.getRawClass()); | |||
There was a problem hiding this comment.
Needed to parse response data. But in further testing this breaks Tag.delete
|
Should not be merged as it breaks |
|
@thewheat ok .. will leave this for now and focus on other open PRs |
|
For reference PR to parse Will need to merge that first before merging this |
thewheat
force-pushed
the
timlim/add-participant-functionality
branch
from
d1a24e8
to
7b4f618
Compare
thewheat
force-pushed
the
timlim/add-participant-functionality
branch
from
7b4f618
to
4b63f9e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support for adding and removing of participants from group conversations
Participantclass as we're usingCustomerin the response for conversations ratings Add conversation ratings support #235 and also in the return response for the added methodsRelated Docs: