Update XED_NORETURN to support modern C standards
#333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `XED_NORETURN` macro is incompatible with software using C11. This commit updates the macro logic to use `[[noreturn]]` (C23) or `_Noreturn` (C11) when the given standard is supported. The original `__attribute__` syntax is kept, it now uses `__noreturn__` to avoid conflicts if/when `noreturn` is a macro. Signed-off-by: Jonathon Anderson <[email protected]>
|
A fix will be available with the upcoming external release. |
marjevan
added
the
upcoming release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #332
The
XED_NORETURNmacro is incompatible with software using C11. Update the macro logic to use the C23[[noreturn]]attribute syntax or C11_Noreturnkeyword respectively when the standard is in use. For compatibility with C99, the GNU extension__attribute__((__noreturn__))is used as a fallback, which does not cause compile warnings ifnoreturnis a macro (e.g. fromstdnoreturn.h).