Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/Enhance node management. #1301

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

BalaBalaYi
Copy link
Collaborator

What changes were proposed in this pull request?

  1. Add 'deletion_timestamp' condition when judging whether there is another same pod running. To avoid mistakenly identifying the current pod(to be removed) as the target.
  2. Still need judgement when there is 0 pod list from k8s.

Why are the changes needed?

Fix/Enhance node management.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

UT and training.

Copy link

codecov bot commented Oct 18, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 80.42%. Comparing base (e88d7eb) to head (16cf7d1).

Files with missing lines Patch % Lines
dlrover/python/master/node/dist_job_manager.py 80.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1301      +/-   ##
==========================================
+ Coverage   80.40%   80.42%   +0.01%     
==========================================
  Files         222      222              
  Lines       20544    20553       +9     
==========================================
+ Hits        16518    16529      +11     
+ Misses       4026     4024       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant