Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add exception handler in _get_master_addr_port since the port might b… #1293

Merged

Conversation

majieyue
Copy link
Collaborator

What changes were proposed in this pull request?

add try-exception to protect _get_master_addr_port and add retry of the calling to relieve the port sync problem

Why are the changes needed?

the return value of _get_master_addr_port may be invalid

Does this PR introduce any user-facing change?

No

How was this patch tested?

UT

Copy link

codecov bot commented Oct 12, 2024

Codecov Report

Attention: Patch coverage is 84.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 80.37%. Comparing base (0ef290a) to head (b466f01).
Report is 34 commits behind head on master.

Files with missing lines Patch % Lines
dlrover/python/elastic_agent/torch/training.py 55.55% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1293      +/-   ##
==========================================
+ Coverage   80.34%   80.37%   +0.02%     
==========================================
  Files         222      222              
  Lines       20481    20525      +44     
==========================================
+ Hits        16456    16496      +40     
- Misses       4025     4029       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@samplise samplise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Collaborator

@workingloong workingloong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@majieyue majieyue merged commit fbd0bae into intelligent-machine-learning:master Oct 21, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants