update

intelligent-machine-learning · Oct 11, 2024 · bccb9e9 · bccb9e9
1 parent d594ee2
commit bccb9e9
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 9 deletions.
diff --git a/dlrover/python/diagnosis/common/diagnose_action.py b/dlrover/python/diagnosis/common/diagnose_action.py
@@ -16,7 +16,7 @@
 
 class DiagnoseAction:
  def __init__(self):
- self.actions: List[str] = []
+ self._actions: List[str] = []
 
  def add_action(self, action: str):
- self.actions.append(action)
+ self._actions.append(action)
diff --git a/...renceoperator/collect_metrics_operator.py → ...ceoperator/metrics_collection_operator.py b/...renceoperator/collect_metrics_operator.py → ...ceoperator/metrics_collection_operator.py
@@ -29,7 +29,7 @@
 from dlrover.python.elastic_agent.master_client import MasterClient
 
 
-class CollectMetricsOperator(InferenceOperator):
+class MetricsCollectionOperator(InferenceOperator):
  """
  CollectXPUTimerMetricsOperator is the operator to collect
  XPU timer metrics.

diff --git a/dlrover/python/diagnosis/inferencechain/inferenceoperator/operator.py b/dlrover/python/diagnosis/inferencechain/inferenceoperator/operator.py
@@ -14,8 +14,8 @@
 from dlrover.python.diagnosis.inferencechain.inferenceoperator.check_failure_node_operator import ( # noqa: E501
  CheckFailureNodeOperator,
 )
-from dlrover.python.diagnosis.inferencechain.inferenceoperator.collect_metrics_operator import ( # noqa: E501
- CollectMetricsOperator,
+from dlrover.python.diagnosis.inferencechain.inferenceoperator.metrics_collection_operator import ( # noqa: E501
+ MetricsCollectionOperator,
 )
 
 
@@ -24,7 +24,7 @@ def get_training_failure_operators():
 
 
 def get_worker_observe_operators():
- return [CollectMetricsOperator()]
+ return [MetricsCollectionOperator()]
 
 
 def get_worker_diagnosis_operators():

diff --git a/dlrover/python/tests/test_inference_chain.py b/dlrover/python/tests/test_inference_chain.py
@@ -37,8 +37,8 @@
 from dlrover.python.diagnosis.inferencechain.inferenceoperator.check_training_hang_operator import ( # noqa: E501
  CheckTrainingHangOperator,
 )
-from dlrover.python.diagnosis.inferencechain.inferenceoperator.collect_metrics_operator import ( # noqa: E501
- CollectMetricsOperator,
+from dlrover.python.diagnosis.inferencechain.inferenceoperator.metrics_collection_operator import ( # noqa: E501
+ MetricsCollectionOperator,
 )
 from dlrover.python.elastic_agent.master_client import (
  MasterClient,
@@ -148,7 +148,7 @@ def test_inference_chain(self):
  )
  def test_collect_metrics_operator(self, mock_collector):
  mock_collector.return_value = "data"
- operator = CollectMetricsOperator()
+ operator = MetricsCollectionOperator()
  inf = Inference(
  name=InferenceName.WORKER,
  attribution=InferenceAttribute.COLLECT,