[SYCL][E2E] Fix typos in REQUIRES: lit lines #15767
Open
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarnex
reviewed
Oct 18, 2024
| @@ -6,7 +6,7 @@ | |||
| // | |||
| //===----------------------------------------------------------------------===// | |||
| // Recursion is not supported in ESIMD (intel/llvm PR#3390) | |||
| // REQUIRES: TEMPORARY_DISBLED | |||
There was a problem hiding this comment.
can we just delete this test and sycl/test-e2e/ESIMD/fp_call_recursive.cpp? sycl doesn't allow recursive functions so i don't know why we have forever disabled tests for behavior the language doesn't allow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The capitalization of cuda and hip in
Basic/interop/interop_all_backends.cppmakes the test always unsupported. This patch should fix this to allow the test to run again on machines with cuda/hip devices.The typo in TEMPORARY_DISABLED in
ESIMD/noinline_call_recursive.cpphas no effect on the test, as it is never ran in either case.