fix multiplication IR

intel · Mar 25, 2023 · 5c7f06c · 5c7f06c
1 parent 3326a26
commit 5c7f06c
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/omniscidb/QueryEngine/ArithmeticIR.cpp b/omniscidb/QueryEngine/ArithmeticIR.cpp
@@ -394,10 +394,11 @@ llvm::Value* CodeGenerator::codegenMul(const hdk::ir::BinOper* bin_oper,
         cgen_state_->ir_builder_.CreateICmpEQ(rhs_lv, const_zero), mul_ok, mul_check);
     cgen_state_->ir_builder_.SetInsertPoint(mul_check);
     auto rhs_is_negative_lv = cgen_state_->ir_builder_.CreateICmpSLT(rhs_lv, const_zero);
+    auto lhs_is_negative_lv = cgen_state_->ir_builder_.CreateICmpSLT(lhs_lv, const_zero);
     auto positive_rhs_lv = cgen_state_->ir_builder_.CreateSelect(
         rhs_is_negative_lv, cgen_state_->ir_builder_.CreateNeg(rhs_lv), rhs_lv);
     auto adjusted_lhs_lv = cgen_state_->ir_builder_.CreateSelect(
-        rhs_is_negative_lv, cgen_state_->ir_builder_.CreateNeg(lhs_lv), lhs_lv);
+        lhs_is_negative_lv, cgen_state_->ir_builder_.CreateNeg(lhs_lv), lhs_lv);
     auto detected = cgen_state_->ir_builder_.CreateOr(  // overflow
         cgen_state_->ir_builder_.CreateICmpSGT(
             adjusted_lhs_lv,

diff --git a/omniscidb/Tests/IntelGPUEnablingTest.cpp b/omniscidb/Tests/IntelGPUEnablingTest.cpp
@@ -377,7 +377,6 @@ TEST_F(AggregationTest, Sum) {
 }
 
 TEST_F(AggregationTest, FilterAndSum) {
-  GTEST_SKIP();
   c("SELECT SUM(x * dd) FROM test;", g_dt);
   c("SELECT SUM(y * dd) FROM test;", g_dt);
   c("SELECT SUM(w * dd) FROM test;", g_dt);