-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the user key to the set of tests in the test.yaml file #476
base: main
Are you sure you want to change the base?
Conversation
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jafraustro it seems that we are missing the group ID change from your last PR. Is that on purpose?
Please update your branch also.
226e337
to
6056cd2
Compare
Signed-off-by: jafraustro <[email protected]>
Signed-off-by: jafraustro <[email protected]>
Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: jafraustro <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Signed-off-by: jafraustro <[email protected]>
Signed-off-by: jafraustro <[email protected]>
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
Thanks Tyler, GID variable is added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests not passing, please fix before approval.
Also a more descriptive name would help
user
property to test.yml
user
property to test.yml
Integration Test ResultsGroups Tested: preset/deep-learning, preset/inference-optimization Results
Overall Result: FAIL ❌ |
Description
Update tests.yaml files with
user: root
Changes Made
The command
groupadd -g 109 render
creates a new group called render with the Group ID 109. Some tests failed because the RENDER group set inside the container (109) mismatches with the RENDER group of the runner. As workaround, some test need to be run asroot user