Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Caching to scan-container #463

Merged
merged 10 commits into from
Oct 18, 2024
Merged

Conversation

tylertitsworth
Copy link
Contributor

@tylertitsworth tylertitsworth commented Oct 17, 2024

Description

Related Issue

MLOPS-2153

Changes Made

  • The code follows the project's coding standards.
  • No Intel Internal IP is present within the changes.
  • The documentation has been updated to reflect any changes in functionality.

Validation

  • I have tested any changes in container groups locally with test_runner.py with all existing tests passing, and I have added new tests where applicable.

tylertitsworth added 2 commits October 17, 2024 09:06
Signed-off-by: tylertitsworth <[email protected]>
Signed-off-by: tylertitsworth <[email protected]>
Copy link

github-actions bot commented Oct 17, 2024

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails
actions/aquasecurity/trivy-action 915b19bbe73b92a6cf82a1bc12b087c9a19a5fe2 🟢 5.7
Details
CheckScoreReason
Maintained🟢 1010 commit(s) and 11 issue activity found in the last 90 days -- score normalized to 10
Code-Review🟢 8Found 25/30 approved changesets -- score normalized to 8
CII-Best-Practices⚠️ 0no effort to earn an OpenSSF best practices badge detected
License🟢 10license file detected
Binary-Artifacts🟢 10no binaries found in the repo
Packaging⚠️ -1packaging workflow not detected
Dangerous-Workflow🟢 10no dangerous workflow patterns detected
Token-Permissions⚠️ 0detected GitHub workflow tokens with excessive permissions
Pinned-Dependencies⚠️ 0dependency not pinned by hash detected -- score normalized to 0
Signed-Releases⚠️ -1no releases found
Branch-Protection⚠️ -1internal error: error during branchesHandler.setup: internal error: githubv4.Query: Resource not accessible by integration
Vulnerabilities🟢 100 existing vulnerabilities detected
Fuzzing⚠️ 0project is not fuzzed
Security-Policy⚠️ 0security policy file not detected
SAST⚠️ 0SAST tool is not run on all commits -- score normalized to 0

Scanned Manifest Files

.github/workflows/container-ci.yaml

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

tylertitsworth added 5 commits October 17, 2024 10:35
Signed-off-by: tylertitsworth <[email protected]>
Signed-off-by: tylertitsworth <[email protected]>
Signed-off-by: tylertitsworth <[email protected]>
Signed-off-by: tylertitsworth <[email protected]>
Signed-off-by: tylertitsworth <[email protected]>
Copy link

Integration Test Results

Groups Tested: pytorch/serving, pytorch/tests

Results
Test-Group Test Status
pytorch/serving ipex-serving-cpu-model-archive PASS
pytorch/serving ipex-serving-cpu-workflow-archive PASS
pytorch/serving ipex-serving-cpu-rest-workflow PASS
pytorch/serving ipex-serving-cpu-rest-inference PASS
pytorch/serving ipex-serving-cpu-grpc-inference PASS
pytorch/serving ipex-serving-xpu-model-archive PASS
pytorch/serving ipex-serving-xpu-rest-inference PASS
pytorch/tests import-ipex-cpu-idp PASS
pytorch/tests import-ipex-cpu-pip PASS
pytorch/tests import-ipex-xpu-idp PASS
pytorch/tests import-ipex-xpu-pip PASS
pytorch/tests import-cpu-jupyter-idp PASS
pytorch/tests import-cpu-jupyter-pip PASS
pytorch/tests import-xpu-jupyter-idp PASS
pytorch/tests import-xpu-jupyter-pip PASS
pytorch/tests ipex-cpu-idp PASS
pytorch/tests ipex-cpu-pip PASS
pytorch/tests ipex-xpu-idp PASS
pytorch/tests ipex-xpu-pip PASS
pytorch/tests ipex-xpu-jupyter-idp PASS
pytorch/tests ipex-xpu-jupyter-pip PASS

Overall Result: PASS ✅

Signed-off-by: tylertitsworth <[email protected]>
@tylertitsworth tylertitsworth removed the WIP Work in Progress label Oct 17, 2024
Copy link
Contributor

@sramakintel sramakintel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks

@tylertitsworth tylertitsworth merged commit e890bf4 into main Oct 18, 2024
23 checks passed
@tylertitsworth tylertitsworth deleted the tylertitsworth/trivy-cache branch October 18, 2024 04:14
jafraustro pushed a commit that referenced this pull request Oct 21, 2024
Signed-off-by: tylertitsworth <[email protected]>
Signed-off-by: jafraustro <[email protected]>
jafraustro pushed a commit that referenced this pull request Oct 21, 2024
Signed-off-by: tylertitsworth <[email protected]>
Signed-off-by: jafraustro <[email protected]>
jafraustro pushed a commit that referenced this pull request Oct 21, 2024
Signed-off-by: tylertitsworth <[email protected]>
Signed-off-by: jafraustro <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants