(fix): add the handlers for empty values #2404
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit add the control of the allowed_repositories and the allowed_actions for the actions_permission resources. Without them the API calls will fail because the allowed_actions and the allowed_repository are passed to the API with a null value. The patch removes them from the HTTP request.
|
Is there an issue that this resolves? Can you add test cases to validate this behavior for the future? |
|
@kfcampbell I created the issue for it, happy to add further details if required. #2405 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit add the control of the allowed_repositories and the allowed_actions for the actions_permission resources. Without them the API calls will fail because the allowed_actions and the allowed_repository are passed to the API with a null value.
The patch removes them from the HTTP request.
Resolves #2405
Before the change?
After the change?
Pull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!