uhd geometry #38
Merged
uhd geometry #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliche
reviewed
Aug 13, 2024
There was a problem hiding this comment.
It's great to have the grid definitions as a constant at the top of the module.
I would recommend writing some quick tests and ensure there is no regression.
- from
maincreate a simple test that calls the dense layout function and assert the current outputs - commit and merge into your branch
- test again to make sure the output hasn't changed
- do the same with UHD
I think the functions are covered as part of integration tests, but a regression here could have massive impact on our spike sorting !
oliche
approved these changes
Aug 20, 2024
|
Added spikeglx sample meta file. Note the version is called |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.