Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix video codec probing #180

Merged
merged 8 commits into from
Aug 23, 2024
Merged

Fix video codec probing #180

merged 8 commits into from
Aug 23, 2024

Conversation

alexlapa
Copy link
Contributor

@alexlapa alexlapa commented Aug 13, 2024 •
edited by tyranron
Loading

Synopsis

Client currently incorrectly sets list of preferred codecs, picking the first one that fits according to getCapabilities result disregarding the fact that each codec can have multiple entries with different settings. So if we limit server capabilities to VP9 with profile-0, client might set VP9 profile-2 via setCodecpreferences thus failing to negotiate.

Checklist

  • Created PR:
    • In draft mode
    • Name contains issue reference
    • Has type and k:: labels applied
    • Has assignee
  • Before review:
    • Documentation is updated (if required)
    • Tests are updated (if required)
    • Changes conform code style
    • CHANGELOG entry is added (if required)
    • FCM (final commit message) is posted or updated
    • Draft mode is removed
  • Review is completed and changes are approved
    • FCM (final commit message) is approved
  • Before merge:
    • Milestone is set
    • PR's name and description are correct and up-to-date
    • All temporary labels are removed

@alexlapa alexlapa added enhancement Improvement of existing features or bugfix k::refactor Refactoring, technical debt elimination and other improvements of existing code base platform::android Specific to Android platform platform::ios Specific to iOS platform platform::web Specific to WEB platform platform::windows Specific to Windows platform platform::linux Specific to Linux platform platform::macos Specific to macOS platform labels Aug 13, 2024
@alexlapa alexlapa marked this pull request as ready for review August 22, 2024 14:53
@alexlapa alexlapa self-assigned this Aug 22, 2024
@alexlapa
Copy link
Contributor Author

FCM:

Fix video codec probing being too strict (#180)

@tyranron tyranron merged commit d786da8 into master Aug 23, 2024
53 checks passed
@tyranron tyranron deleted the refactor_set_codec_prefs branch August 23, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evdokimovs evdokimovs evdokimovs approved these changes

@tyranron tyranron tyranron approved these changes

Assignees

@alexlapa alexlapa

Labels
enhancement Improvement of existing features or bugfix k::refactor Refactoring, technical debt elimination and other improvements of existing code base platform::android Specific to Android platform platform::ios Specific to iOS platform platform::linux Specific to Linux platform platform::macos Specific to macOS platform platform::web Specific to WEB platform platform::windows Specific to Windows platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexlapa @tyranron @evdokimovs