Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SFU reconnect test #143

Merged
merged 1 commit into from
Dec 21, 2023
Merged

Fix SFU reconnect test #143

merged 1 commit into from
Dec 21, 2023

Conversation

rogurotus
Copy link
Contributor

@rogurotus rogurotus commented Dec 21, 2023 •
edited by tyranron
Loading

Synopsis

blinking screenshare render when new user connects

Checklist

  • Created PR:
    • In draft mode
    • Name contains Draft: prefix
    • Name contains issue reference
    • Has k:: labels applied
    • Has assignee
  • Documentation is updated (if required)
  • Tests are updated (if required)
  • Changes conform code style
  • CHANGELOG entry is added (if required)
  • FCM (final commit message) is posted
    • and approved
  • Review is completed and changes are approved
  • Before merge:
    • Milestone is set
    • PR's name and description are correct and up-to-date
    • Draft: prefix is removed
    • All temporary labels are removed

@rogurotus rogurotus added enhancement Improvement of existing features or bugfix k::testing Related to testing and/or automated tests platform::android Specific to Android platform platform::ios Specific to iOS platform platform::web Specific to WEB platform platform::windows Specific to Windows platform platform::linux Specific to Linux platform platform::macos Specific to macOS platform labels Dec 21, 2023
@rogurotus rogurotus self-assigned this Dec 21, 2023
@rogurotus
Copy link
Contributor Author

FCM

Fix SFU reconnect test (#143)

@alexlapa alexlapa marked this pull request as ready for review December 21, 2023 14:43
@tyranron tyranron merged commit 3fb7389 into master Dec 21, 2023
52 checks passed
@tyranron tyranron deleted the fix-sfu-reconnect-test branch December 21, 2023 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexlapa alexlapa alexlapa approved these changes

@tyranron tyranron tyranron approved these changes

Assignees

@rogurotus rogurotus

Labels
enhancement Improvement of existing features or bugfix k::testing Related to testing and/or automated tests platform::android Specific to Android platform platform::ios Specific to iOS platform platform::linux Specific to Linux platform platform::macos Specific to macOS platform platform::web Specific to WEB platform platform::windows Specific to Windows platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rogurotus @tyranron @alexlapa