Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix false positive web tests #128

Merged
merged 50 commits into from
Dec 5, 2023
Merged

Fix false positive web tests #128

merged 50 commits into from
Dec 5, 2023

Conversation

rogurotus
Copy link
Contributor

@rogurotus rogurotus commented Aug 31, 2023 •
edited by tyranron
Loading

Synopsis

False positive connection loss tests for web.

Checklist

  • Created PR:
    • In draft mode
    • Name contains Draft: prefix
    • Name contains issue reference
    • Has k:: labels applied
    • Has assignee
  • Documentation is updated (if required)
  • Tests are updated (if required)
  • Changes conform code style
  • CHANGELOG entry is added (if required)
  • FCM (final commit message) is posted
    • and approved
  • Review is completed and changes are approved
  • Before merge:
    • Milestone is set
    • PR's name and description are correct and up-to-date
    • Draft: prefix is removed
    • All temporary labels are removed

logist322 and others added 30 commits July 17, 2023 12:28
@rogurotus
Copy link
Contributor Author

rogurotus commented Aug 31, 2023 •
edited by alexlapa
Loading

FCM

Fix connection loss e2e tests on web (#128)

@rogurotus rogurotus marked this pull request as ready for review August 31, 2023 19:26
@rogurotus rogurotus self-assigned this Sep 1, 2023
@rogurotus rogurotus added enhancement Improvement of existing features or bugfix k::testing Related to testing and/or automated tests platform::web Specific to WEB platform labels Sep 1, 2023
alexlapa and others added 8 commits November 29, 2023 19:11
@alexlapa
Merge branch 'master' into fix-web-connection-loss
3477b5c 
# Conflicts:
#	Cargo.lock
#	e2e/tests/steps/track.rs
#	e2e/tests/world/member.rs
#	e2e/tests/world/mod.rs
#	flutter/test/e2e/steps/track.dart
#	flutter/test/e2e/world/member.dart
#	src/room.rs
@alexlapa
corrections
06f7ee8
@alexlapa
corrections
5829c65
@rogurotus
error refact
b5419b8
@rogurotus
fix fmt
dac1d7d
@alexlapa
corrections
48b6e1b
@alexlapa
trigger ci
39d825c
@alexlapa
corrections
32e3f2e
@tyranron tyranron merged commit 7387cf4 into master Dec 5, 2023
52 checks passed
@tyranron tyranron deleted the fix-web-connection-loss branch December 5, 2023 14:16
@tyranron tyranron added the k::refactor Refactoring, technical debt elimination and other improvements of existing code base label Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexlapa alexlapa alexlapa approved these changes

@tyranron tyranron tyranron approved these changes

Assignees

@rogurotus rogurotus

Labels
enhancement Improvement of existing features or bugfix k::refactor Refactoring, technical debt elimination and other improvements of existing code base k::testing Related to testing and/or automated tests platform::web Specific to WEB platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rogurotus @tyranron @alexlapa @logist322