Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix blink direction #122

Merged
merged 19 commits into from
Jan 8, 2024
Merged

Fix blink direction #122

merged 19 commits into from
Jan 8, 2024

Conversation

rogurotus
Copy link
Contributor

@rogurotus rogurotus commented Jul 7, 2023 •
edited by tyranron
Loading

Synopsis

blinking screenshare render when new user connects

Checklist

  • Created PR:
    • In draft mode
    • Name contains Draft: prefix
    • Name contains issue reference
    • Has k:: labels applied
    • Has assignee
  • Documentation is updated (if required)
  • Tests are updated (if required)
  • Changes conform code style
  • CHANGELOG entry is added (if required)
  • FCM (final commit message) is posted
    • and approved
  • Review is completed and changes are approved
  • Before merge:
    • Milestone is set
    • PR's name and description are correct and up-to-date
    • Draft: prefix is removed
    • All temporary labels are removed

@rogurotus rogurotus added enhancement Improvement of existing features or bugfix k::api Related to API (application interface) platform::android Specific to Android platform platform::ios Specific to iOS platform platform::web Specific to WEB platform platform::windows Specific to Windows platform platform::linux Specific to Linux platform platform::macos Specific to macOS platform labels Jul 7, 2023
@rogurotus rogurotus self-assigned this Jul 7, 2023
@rogurotus
Copy link
Contributor Author

rogurotus commented Jul 7, 2023 •
edited by alexlapa
Loading

FCM

Fix incoming track initial direction being incorrect (#122)

@rogurotus rogurotus requested a review from alexlapa July 7, 2023 15:04
@rogurotus rogurotus marked this pull request as ready for review July 7, 2023 15:04
@tyranron tyranron force-pushed the master branch 2 times, most recently from 60f95e0 to 4f64c04 Compare January 3, 2024 13:49
@alexlapa alexlapa requested a review from tyranron January 8, 2024 10:39
@tyranron tyranron added k::ui/ux Related to UI/UX experience and removed k::api Related to API (application interface) labels Jan 8, 2024
@tyranron tyranron merged commit f3fa3ca into master Jan 8, 2024
52 checks passed
@tyranron tyranron deleted the fix-blink-direction branch January 8, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexlapa alexlapa alexlapa approved these changes

@tyranron tyranron tyranron approved these changes

Assignees

@rogurotus rogurotus

Labels
enhancement Improvement of existing features or bugfix k::ui/ux Related to UI/UX experience platform::android Specific to Android platform platform::ios Specific to iOS platform platform::linux Specific to Linux platform platform::macos Specific to macOS platform platform::web Specific to WEB platform platform::windows Specific to Windows platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rogurotus @tyranron @alexlapa