Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implements extended API for creating RtcRtpTransceivers #125

Merged
merged 24 commits into from
Oct 4, 2023
Merged

Implements extended API for creating RtcRtpTransceivers #125

merged 24 commits into from
Oct 4, 2023

Conversation

logist322
Copy link

@logist322 logist322 commented Sep 28, 2023 •
edited by tyranron
Loading

Synopsis

Implements extended API for creating RtcRtpTransceivers.

Checklist

  • Created PR:
    • In draft mode
    • Name contains issue reference
    • Has type and k:: labels applied
    • Has assignee
  • Before review:
    • Documentation is updated (if required)
    • Tests are updated (if required)
    • Changes conform code style
    • CHANGELOG entry is added (if required)
    • FCM (final commit message) is posted or updated
    • Draft mode is removed
  • Review is completed and changes are approved
    • FCM (final commit message) is approved
  • Before merge:
    • Milestone is set
    • PR's name and description are correct and up-to-date
    • All temporary labels are removed

@logist322 logist322 added k::api Related to API (application interface) feature New feature or request labels Sep 28, 2023
@logist322 logist322 self-assigned this Sep 28, 2023
@logist322 logist322 changed the title WIP Implements extended API for creating RtcRtpTransceivers. Sep 28, 2023
@logist322 logist322 changed the title Implements extended API for creating RtcRtpTransceivers. Implements extended API for creating RtcRtpTransceivers Sep 28, 2023
@logist322 logist322 marked this pull request as ready for review September 29, 2023 09:03
@logist322
Copy link
Author

logist322 commented Sep 29, 2023 •
edited by tyranron
Loading

FCM

Support `RTCRtpTransceiverInit.sendEncodings` (#125)

@alexlapa alexlapa requested a review from tyranron October 3, 2023 14:27
@tyranron tyranron enabled auto-merge (squash) October 4, 2023 13:41
@tyranron tyranron merged commit 0833c9a into main Oct 4, 2023
19 of 22 checks passed
@tyranron tyranron deleted the add-send-encodings branch October 4, 2023 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexlapa alexlapa alexlapa approved these changes

@tyranron tyranron tyranron approved these changes

Assignees

@logist322 logist322

Labels
feature New feature or request k::api Related to API (application interface)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@logist322 @tyranron @alexlapa