Add RTCYUVHelper for iOS and MacOS
#107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evdokimovs
added
enhancement
FCMAdd `RTCYUVHelper` for iOS and macOS (#107) |
tyranron
approved these changes
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a part of instrumentisto/medea-flutter-webrtc#162 we're migrating to the Apple Silicon CI runners for the better iOS integration tests performance. But we have one problem with this migration: currently we're using
libyuv-IOSpod forRTCI420Bufferconvertions in iOS renderer code, but this pod is outdated and wasn't built for ARM64-Simulator arch. There are no alternatives and creating new fork for this looks too complicated. Butlibwebrtcis also using this library under the hood, so we can just add public APIs for this underlying library and use it in our iOS code in instrumentisto/medea-flutter-webrtc instead oflibyuvdependency.So this PR adds required APIs for the iOS and MacOS platforms.