Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Broker's Dockerfile won't build #932

Merged
merged 1 commit into from
Mar 28, 2023
Merged

Conversation

ysbaddaden
Copy link
Contributor

@ysbaddaden ysbaddaden commented Mar 24, 2023

  • Debian Jessie was moved to archive.debian.org (long deprecated)
  • APT keys expired in June 2020

@ysbaddaden
Copy link
Contributor Author

Some upgrade notes: if we could update to Erlang 18, we'd be able to move on to Debian Stretch (as the main Ruby image) which was last built 9 months ago (instead of 4 years ago)... same for Erlang 19 (Stretch, 9 months ago) while Erlang 20 was last built 3 days ago (Buster) 👍

Copy link
Member

@matiasgarciaisaia matiasgarciaisaia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

I guess upgrading the tech stack would be part of a future effort.

@ysbaddaden ysbaddaden merged commit ed1608d into master Mar 28, 2023
@ysbaddaden ysbaddaden deleted the fix/broken-dockerfiles branch March 28, 2023 09:19
@ysbaddaden
Copy link
Contributor Author

I tried to build an image from erlang:18.3. It doesn't hurt to try, but poirot fails to build because it triggers the one deprecation in ERTS from Erlang 18 😆

The deprecation shouldn't fail the build (it's backward compatible), but we treat warnings as errors in both verboice/broker and poirot.

@matiasgarciaisaia
Copy link
Member

Poirot is dead, so let's remove it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants