Blinding date_produced for samples and keeping samples order for send… #2001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ysbaddaden
reviewed
Apr 18, 2024
There was a problem hiding this comment.
Checking for the "Blinded" string is indeed prone to break in very unexpected ways. Maybe you can reuse #blinded_attribute(name, &) that we use in the forms? It's meant to print "Blinded" or do something else that depends on the context.
sample.blinded_attribute(:date_produced) { sample.date_produced.to_date }
|
CI failure is fine: it's a |
ysbaddaden
reviewed
Apr 18, 2024
app/documents/label_pdf.rb
Outdated
| @@ -41,7 +41,7 @@ def render_sample_details(sample) | |||
| text_lines [ | |||
| "I.N. #{sample.isolate_name}".truncate(22), | |||
| "I.M. #{sample.inactivation_method}".truncate(22), | |||
| "P.D. #{sample.date_produced == "Blinded" ? "Blinded" : sample.date_produced.strftime("%m/%d/%Y")}", | |||
| "P.D. #{sample.blinded_attribute?(:date_produced) ? sample.date_produced : sample.date_produced.strftime("%m/%d/%Y")}", | |||
There was a problem hiding this comment.
That's... confusing :/
What's wrong with the block variant?
There was a problem hiding this comment.
Sorry Julien :(
I didn't understood what you meant first, I did things fast because I thought you were suggesting to do what I did. Now I think is fixed. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested by the client: Blinding date_produced for samples and keeping samples order for sender institution.
Note: for the date field, in order to make things work when blinded, I had to compare to "Blinded" string, which does not feel like the best solution possible.