Allow to enter zero concentration in boxes creation (#1908)

instedd · Feb 9, 2023 · 8b12613 · 8b12613
1 parent f879532
commit 8b12613
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 9 deletions.
diff --git a/app/assets/javascripts/components/box_batches_form.js.jsx b/app/assets/javascripts/components/box_batches_form.js.jsx
@@ -301,7 +301,7 @@ var BoxBatchForm = React.createClass({
   },
 
   isValidConcentration: function (c) {
-    return (parseInt(c.replicate, 10) > 0 && parseFloat(c.concentration, 10) > 0);
+    return (parseInt(c.replicate, 10) > 0 && parseFloat(c.concentration, 10) >= 0);
   },
 
   hideForm: function (event) {

diff --git a/app/assets/stylesheets/_batches.scss b/app/assets/stylesheets/_batches.scss
@@ -170,13 +170,9 @@
   display: flex;
   align-items: center;
   margin-left: auto;
-
-  .icon-check {
-    width: 24px;
-    height: 24px;
-    margin-left: 10px;
-    background-size: 100%;
-    cursor: pointer;
+
+  >input{
+    width: 80px;
   }
 }
 

diff --git a/spec/features/boxes_spec.rb b/spec/features/boxes_spec.rb
@@ -64,9 +64,12 @@
 
           # validates concentration field:
           field = batch_form.concentration_fields[0]
-          field.set(0)
+          field.set(-1)
           expect(batch_form.ok.disabled?).to be(true)
 
+          field.set(0)
+          expect(batch_form.ok.disabled?).to be(false)
+
           field.set(2)
           expect(batch_form.ok.disabled?).to be(false)
         end