fix: make multiple scopes work. #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EddeCCC
requested changes
Sep 9, 2024
.../gepard/agent/internal/configuration/model/instrumentation/InstrumentationConfiguration.java
Outdated
Show resolved
Hide resolved
src/main/java/rocks/inspectit/gepard/agent/resolver/ConfigurationResolver.java
Outdated
Show resolved
Hide resolved
src/main/java/rocks/inspectit/gepard/agent/resolver/ConfigurationResolver.java
Outdated
Show resolved
Hide resolved
src/main/java/rocks/inspectit/gepard/agent/resolver/ConfigurationResolver.java
Outdated
Show resolved
Hide resolved
EddeCCC
requested changes
Sep 10, 2024
src/test/java/rocks/inspectit/gepard/agent/resolver/matcher/CustomElementMatchersTest.java
Outdated
Show resolved
Hide resolved
src/main/java/rocks/inspectit/gepard/agent/resolver/matcher/MatcherChainBuilder.java
Outdated
Show resolved
Hide resolved
src/main/java/rocks/inspectit/gepard/agent/resolver/matcher/MatcherChainBuilder.java
Show resolved
Hide resolved
src/main/java/rocks/inspectit/gepard/agent/resolver/matcher/MatcherChainBuilder.java
Show resolved
Hide resolved
src/main/java/rocks/inspectit/gepard/agent/resolver/matcher/MatcherChainBuilder.java
Show resolved
Hide resolved
src/main/java/rocks/inspectit/gepard/agent/resolver/scope/ScopeResolver.java
Show resolved
Hide resolved
src/main/java/rocks/inspectit/gepard/agent/resolver/scope/ScopeResolver.java
Outdated
Show resolved
Hide resolved
src/main/java/rocks/inspectit/gepard/agent/resolver/scope/ScopeResolver.java
Outdated
Show resolved
Hide resolved
src/main/java/rocks/inspectit/gepard/agent/resolver/matcher/MatcherChainBuilder.java
Show resolved
Hide resolved
src/main/java/rocks/inspectit/gepard/agent/resolver/scope/ScopeResolver.java
Show resolved
Hide resolved
|
EddeCCC
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ConfigurationResolver had only access to the first scope with the same fqn (See: InstrumentationConfiguration.java).
Thus only one scope works, if there are multiple with the same fqn.
Now all Scopes, where the fqn is included are returned to ConfigurationResolver.
Have to flatten the MethodNames of the Scope-List now before I pass them into the MethodMatcher.
Dont like ConfigurationResolver.java:94:
ElementMatchers.namedOneOf(methodNames.toArray(String[]::new));Is there any prettier syntax to convert that list to a stinknormal array?