refactor: sonarcloud issues

inspectIT · Oct 7, 2024 · 8c65a4e · 8c65a4e
1 parent 67d4fed
commit 8c65a4e
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 8 deletions.
diff --git a/...ard-agent/src/main/java/rocks/inspectit/gepard/agent/instrumentation/hook/MethodHook.java b/...ard-agent/src/main/java/rocks/inspectit/gepard/agent/instrumentation/hook/MethodHook.java
@@ -31,8 +31,8 @@ public InternalInspectitContext onEnter(Object[] instrumentedMethodArgs, Object
 
     try {
       spanScope = spanAction.startSpan(spanName);
-    } catch (Throwable t) {
-      log.error("Could not execute start-span-action", t);
+    } catch (Exception e) {
+      log.error("Could not execute start-span-action", e);
     }
 
     // Using our log4j here will not be visible in the target application...
@@ -50,8 +50,8 @@ public void onExit(
     AutoCloseable spanScope = context.getSpanScope();
     try {
       spanAction.endSpan(spanScope);
-    } catch (Throwable t) {
-      log.error("Could not execute end-span-action", t);
+    } catch (Exception e) {
+      log.error("Could not execute end-span-action", e);
     }
 
     // Using our log4j here will not be visible in the target application...

diff --git a/...rd-agent/src/main/java/rocks/inspectit/gepard/agent/transformation/InspectitListener.java b/...rd-agent/src/main/java/rocks/inspectit/gepard/agent/transformation/InspectitListener.java
@@ -27,24 +27,32 @@ public void onError(
 
   @Override
   public void onDiscovery(
-      String typeName, ClassLoader classLoader, JavaModule module, boolean loaded) {}
+      String typeName, ClassLoader classLoader, JavaModule module, boolean loaded) {
+    // unused
+  }
 
   @Override
   public void onTransformation(
       TypeDescription typeDescription,
       ClassLoader classLoader,
       JavaModule module,
       boolean loaded,
-      DynamicType dynamicType) {}
+      DynamicType dynamicType) {
+    // unused
+  }
 
   @Override
   public void onIgnored(
       TypeDescription typeDescription,
       ClassLoader classLoader,
       JavaModule module,
-      boolean loaded) {}
+      boolean loaded) {
+    // unused
+  }
 
   @Override
   public void onComplete(
-      String typeName, ClassLoader classLoader, JavaModule module, boolean loaded) {}
+      String typeName, ClassLoader classLoader, JavaModule module, boolean loaded) {
+    // unused
+  }
 }