fix(nami): add bech32 encoding fallback for nami mode #1486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
implement try/catch with undefined fallback prevents nami crashing if bech32 or base8 decode fails, or throws due to: - invalid string length - mixed formatting - any other issue related to encoding
|
Allure Report
processReports: ✅ test report for 406c7806
|
ljagiela
approved these changes
Oct 29, 2024
mchappell
added a commit
that referenced
this pull request
Oct 29, 2024
implement try/catch with undefined fallback prevents nami crashing if bech32 or base8 decode fails, or throws due to: - invalid string length - mixed formatting - any other issue related to encoding
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implement try/catch with undefined fallback
prevents nami crashing if bech32 or base8 decode fails, or throws due to:
Checklist
Proposed solution
Added try/catch with additional attempt to cast as byron address, with appropriate error fallback
Testing
Use same wallet addr provided in the companion PR before and after applying these changes