Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): bash autocomplete affecting on global flags #76

Merged
merged 37 commits into from
Oct 21, 2024

Conversation

apskhem
Copy link
Contributor

@apskhem apskhem commented Oct 17, 2024

From the previous PR (#72), the autocomplete works well but it caused issues related to global flags.
This PR is to address that problem.

Screenshot 2024-10-18 at 01 22 47 Screenshot 2024-10-18 at 01 23 26

@apskhem apskhem self-assigned this Oct 17, 2024
@apskhem apskhem marked this pull request as draft October 17, 2024 18:06
@apskhem apskhem requested a review from jmgilman October 17, 2024 18:25
@apskhem apskhem marked this pull request as ready for review October 17, 2024 18:25
@apskhem apskhem changed the title feat(cli): fix bash autocomplete affecting on global flags feat(cli): bash autocomplete affecting on global flags Oct 17, 2024
@stevenj
Copy link
Contributor

stevenj commented Oct 21, 2024

@jmgilman Any comments on this PR?

@jmgilman jmgilman merged commit 64d5f7e into master Oct 21, 2024
20 checks passed
@apskhem apskhem deleted the feat/devx-autocomplete branch October 22, 2024 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants